Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Image crop gpu support #16464

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Image crop gpu support #16464

merged 1 commit into from
Oct 19, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Oct 13, 2019

Description

  1. add gpu support on image crop
  2. remove the duplicate unit test

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

@stu1130 stu1130 force-pushed the crop_gpu branch 5 times, most recently from 7a0b03c to f556bc3 Compare October 15, 2019 01:17
@stu1130 stu1130 changed the title [WIP] Image crop gpu support Image crop gpu support Oct 15, 2019
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

tests/python/gpu/test_gluon_transforms.py Outdated Show resolved Hide resolved
@stu1130 stu1130 force-pushed the crop_gpu branch 3 times, most recently from 782bb0a to 063773a Compare October 17, 2019 23:18
@roywei roywei merged commit 27b3e52 into apache:master Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants